Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: don't use current_exe impl from maa_cli mod #78

Merged
merged 20 commits into from
Oct 16, 2023
Merged

Conversation

wangl-cc
Copy link
Member

The maa_cli mod is not available if self feature is disabled.

The `maa_cli` mod is not available if `self` feature is disabled.
@codecov-commenter
Copy link

codecov-commenter commented Oct 14, 2023

Codecov Report

Attention: 3 lines in your changes are missing coverage. Please review.

Comparison is base (c5f7277) 21.59% compared to head (dacf450) 21.57%.

❗ Current head dacf450 differs from pull request most recent head 13f5b67. Consider uploading reports for the commit 13f5b67 to get more accurate results

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #78      +/-   ##
==========================================
- Coverage   21.59%   21.57%   -0.02%     
==========================================
  Files          20       20              
  Lines        1468     1469       +1     
==========================================
  Hits          317      317              
- Misses       1151     1152       +1     
Files Coverage Δ
maa-cli/src/installer/maa_cli.rs 0.00% <ø> (ø)
maa-cli/src/installer/maa_core.rs 4.00% <0.00%> (-0.09%) ⬇️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@wangl-cc wangl-cc merged commit d813338 into main Oct 16, 2023
11 checks passed
@wangl-cc wangl-cc deleted the fix/non-self branch October 16, 2023 10:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants